Tier Options to KeyVault

[melonrush13]

Closes #600

What this PR does / why we need it:
When creating a KeyVault on the Azure portal, users can create a KV of tier options "Standard" and "Premium"
This PR allows user to have the flexibility to choose one of these options in the yaml.

Special notes for your reviewer:
Create a KV with sku.Name = "Premium" in yaml
Create a KV with sku.Name = "Standard" in yaml

Verify it exists in portal with proper tier

How does this PR make you feel:

If applicable:

• this PR contains documentation
• this PR contains tests

[melonrush13]

My question to reviewer / whoever: When we create a keyvault with access policies, this is done through the function CreateVault, and access policies are added inside of that function.

That being said, we have a function that is called CreateVaultWithAccessPolicies() which is only used during tests.

I currently added the value sku to this function, (CreateVaultWithAccesPolicies()) but am unsure if it is needed since Keyvault_simple.yaml and keyvault.yaml both use CreateVault() to create a KV.

Thoughts? I think I want to remove it personally :)

[jananivMS]

My question to reviewer / whoever: When we create a keyvault with access policies, this is done through the function CreateVault, and access policies are added inside of that function.

That being said, we have a function that is called CreateVaultWithAccessPolicies() which is only used during tests.

I currently added the value sku to this function, (CreateVaultWithAccesPolicies()) but am unsure if it is needed since Keyvault_simple.yaml and keyvault.yaml both use CreateVault() to create a KV.

Thoughts? I think I want to remove it personally :)

Yes, this is only used in tests. I think we initially had it but then we ended up using the CreateVault one. @cnadolny can you confirm? If we remove we should make sure we dont break those tests though.

[cnadolny]

My question to reviewer / whoever: When we create a keyvault with access policies, this is done through the function CreateVault, and access policies are added inside of that function.
That being said, we have a function that is called CreateVaultWithAccessPolicies() which is only used during tests.
I currently added the value sku to this function, (CreateVaultWithAccesPolicies()) but am unsure if it is needed since Keyvault_simple.yaml and keyvault.yaml both use CreateVault() to create a KV.
Thoughts? I think I want to remove it personally :)

Yes, this is only used in tests. I think we initially had it but then we ended up using the CreateVault one. @cnadolny can you confirm? If we remove we should make sure we dont break those tests though.

Yep - just used in tests. I think it was originally added before we added access policy support to the keyvault spec, removing it and replacing it with CreateVault should be fine.

[jpflueger]

code looks good to me, @jananivMS answered my questions via teams