Rotate SQL User credentials #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpflueger
reviewed
Apr 6, 2020
…-service-operator into sqluser-rollcreds
jpflueger
previously approved these changes
Apr 7, 2020
jpflueger
previously approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537
What this PR does / why we need it:
Currently there is a way to roll admin credentials to the SQL server, but not SQL Database user credentials. This extends SQL Action to add that functionality.
When checking if the user exists or not, the code was using the kube namespaced name exclusively, thus it would always come up as a negative if the secret client was Key Vault. Refactored logic around with
dbUserCustomNamespace, put the check for the sql user secret key value into one function.Special notes for your reviewer:
To test:
rollusercreds. Specify SQL User from above. Observe in Key Vault that credentials have updated.How does this PR make you feel:
If applicable: