Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation for managed identity to make it work for forced namespace mode #863

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

jananivMS
Copy link
Contributor

Closes #656

What this PR does / why we need it:

  • When working with a customer who deployed aad pod identity in force namespaced mode, we discovered we will need to install the azure identity and binding yamls in the same namespace as the pod running with aad pod identity.
  • This updates the documentation and the helm chart yaml for this

Special notes for your reviewer:

  • Follow the instructions to deploy the operator in managed identity mode and make sure it works

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@jananivMS jananivMS requested a review from cnadolny April 1, 2020 17:41
@@ -21,9 +21,11 @@ aad-pod-identity:
azureIdentityBinding:
name: aso-identity-binding
selector: aso_manager_binding
namespace: azureoperator-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that these are not needed, as both the identity and binding already deploy into the azureoperator-system namespace, since I think it's based on the namespace of the pod it's providing the identity for!

@jananivMS jananivMS merged commit 16e79da into Azure:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants