-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: SQL User error on GetDB in transitional state #928
Bug: SQL User error on GetDB in transitional state #928
Conversation
CosmosDB test region workaround (#896)
@frodopwns I rebooted this PR based on your feedback... I'm waiting for tests to run, but things should be ok now |
pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go
Outdated
Show resolved
Hide resolved
pkg/resourcemanager/azuresql/azuresqlvnetrule/azuresqlvnetrule_reconcile.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one error in the vnetrule when i tested it as that file had changes too
pkg/resourcemanager/azuresql/azuresqlvnetrule/azuresqlvnetrule_reconcile.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. tested and works well
Closes #905
Describe the bug
If you deploy a RG, SQLServer, SQLDatabase, SQLFirewall, SQLUser at the same time you will see uncaught errors in the SQL User (and SQL Db) operator.
To Reproduce
put the manifests in a directory and run
kubectl create -f <directory>
...you won't see the errors until just before everything finishes...everything comes up eventually but these errors should still be caught
Expected behavior
no stack traces in logs
Fix
Updated Azure SQL