Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SQL User error on GetDB in transitional state #928

Merged
merged 19 commits into from
Apr 15, 2020
Merged

Bug: SQL User error on GetDB in transitional state #928

merged 19 commits into from
Apr 15, 2020

Conversation

WilliamMortlMicrosoft
Copy link
Contributor

Closes #905

Describe the bug
If you deploy a RG, SQLServer, SQLDatabase, SQLFirewall, SQLUser at the same time you will see uncaught errors in the SQL User (and SQL Db) operator.

2020-04-08T18:30:21.485-0600	ERROR	controller-runtime.controller	Reconciler error	{"controller": "azuresqluser", "request": "default/sqluser1", "error": "1 error occurred:\n\t* sql.DatabasesClient#Get: Failure responding to request: StatusCode=404 -- Original Error: json: cannot unmarshal array into Go struct field serviceError2.details of type map[string]interface {}\n\n"}

To Reproduce
put the manifests in a directory and run kubectl create -f <directory>...you won't see the errors until just before everything finishes...

everything comes up eventually but these errors should still be caught

Expected behavior
no stack traces in logs

Fix
Updated Azure SQL

@WilliamMortlMicrosoft WilliamMortlMicrosoft added bug 🪲 Something isn't working azure-sql high-priority Issues we intend to prioritize (security, outage, blocking bug) labels Apr 13, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft self-assigned this Apr 13, 2020
@WilliamMortlMicrosoft
Copy link
Contributor Author

@frodopwns I rebooted this PR based on your feedback... I'm waiting for tests to run, but things should be ok now

@WilliamMortlMicrosoft WilliamMortlMicrosoft changed the title WIP: Bug: SQL User error on GetDB in transitional state Bug: SQL User error on GetDB in transitional state Apr 13, 2020
@frodopwns frodopwns requested a review from jananivMS April 14, 2020 16:28
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one error in the vnetrule when i tested it as that file had changes too

@jananivMS jananivMS self-requested a review April 15, 2020 17:59
@jananivMS jananivMS dismissed their stale review April 15, 2020 17:59

Re-reviewing now

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. tested and works well

@WilliamMortlMicrosoft WilliamMortlMicrosoft merged commit c843020 into Azure:master Apr 15, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft deleted the errorFix2 branch April 15, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working high-priority Issues we intend to prioritize (security, outage, blocking bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SQL User error on GetDB in transitional state
2 participants