Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ResourceGroup operator to set Provisioning -> False #932

Merged
merged 11 commits into from
Apr 14, 2020
Merged

Update the ResourceGroup operator to set Provisioning -> False #932

merged 11 commits into from
Apr 14, 2020

Conversation

WilliamMortlMicrosoft
Copy link
Contributor

closes #707

Update the reconciler for ResourceGroups to set Provisioning to false when there is any case where the service isn't spun up

Added failed provisioning logic

This should not change any unit tests

@WilliamMortlMicrosoft WilliamMortlMicrosoft added enhancement high-priority Issues we intend to prioritize (security, outage, blocking bug) labels Apr 13, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft self-assigned this Apr 13, 2020
Copy link
Contributor

@jpflueger jpflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jpflueger jpflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamMortlMicrosoft WilliamMortlMicrosoft merged commit 12dc1a8 into Azure:master Apr 14, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft deleted the provisionFixRG branch April 14, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the ResourceGroup operator to set Provisioning -> False
2 participants