-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ResourceGroup operator to set Provisioning -> False #932
Merged
WilliamMortlMicrosoft
merged 11 commits into
Azure:master
from
WilliamMortlMicrosoft:provisionFixRG
Apr 14, 2020
Merged
Update the ResourceGroup operator to set Provisioning -> False #932
WilliamMortlMicrosoft
merged 11 commits into
Azure:master
from
WilliamMortlMicrosoft:provisionFixRG
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmosDB test region workaround (#896)
reset failed provisioning in case the outcome changes
WilliamMortlMicrosoft
added
enhancement
high-priority
Issues we intend to prioritize (security, outage, blocking bug)
labels
Apr 13, 2020
jpflueger
reviewed
Apr 14, 2020
jpflueger
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jpflueger
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #707
Update the reconciler for ResourceGroups to set Provisioning to false when there is any case where the service isn't spun up
Added failed provisioning logic
This should not change any unit tests