saving cosmosdb keys as secrets #935
Conversation
|
|
||
| result, err := client.ListKeys(ctx, groupName, accountName) | ||
| if err != nil { | ||
| return nil, errhelp.NewAzureErrorAzureError(err) |
There was a problem hiding this comment.
normally we just return the error and convert it to an AzureError on the other side...any reason to deviate here?
There was a problem hiding this comment.
I originally did this for all of the AzureCosmosDBManager functions because it would simplify the Ensure function which tend to grow pretty large. I can change it to pass just an error if that's preferrable?
There was a problem hiding this comment.
I think it would be OK as a proposed change to all operators but not a good idea for just this one operator.
There was a problem hiding this comment.
The best thing you can do to clean up the Ensure function would be to reduce the cyclomatic complexity.
There was a problem hiding this comment.
I re-wrote most of the ensure function. I was able to reduce the cyclomatic complexity until I realized I wasn't handling a few error cases so it is about the same as before. I'll let you resolve this one when you feel like it's addressed.
|
/azp test |
|
Command 'test' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closes #879
What this PR does / why we need it:
Saves the connection strings and account keys as secrets.
Special notes for your reviewer:
How does this PR make you feel:
If applicable: