-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dns suffix/fully qualified name based on the cloud environment or from the created object #946
Conversation
Due to the quota limitation on China cloud, could use break points to check the dns suffix of secret for SQL server and SQL failover group (no need to create them successfully), which turned out to be correct: *.database.chinacloudapi.cn. But could not verify on SQL user or psql server without creating them. |
@buhongw7583c I was able to validate Azure SQL server, Azure SQL user and PostgreSQL server on China Cloud. Can you please review the code and approve if it looks good to you? |
Closes #672
What this PR does / why we need it:
Special notes for your reviewer:
Test the following operators in Public and China clouds and make sure the fields in the secrets only have environment appropriate strings (.com or .net for Public cloud, .cn or .chinacloudapi for ChinaCloud)
How does this PR make you feel:
If applicable: