Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes BlobContainer's naming convension inside yaml to match parent #951

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Fixes BlobContainer's naming convension inside yaml to match parent #951

merged 3 commits into from
Apr 15, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Apr 15, 2020

Closes #950

When creating a storage account and a blob container, it is annoying to fix the yamls to match each other since they are parent/child resources. We should use the same name convention for parent/child yamls.

What this PR does / why we need it:

  • Follows naming convention of resourcegroup in yaml
  • Changing accountname to match same name as the storageaccount.yaml

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@melonrush13 melonrush13 merged commit beceea1 into Azure:master Apr 15, 2020
@melonrush13 melonrush13 deleted the yamlnamefix branch April 15, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Yaml naming convensions for Storage/Blob
2 participants