Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResourceID to VirtualNetwork #952

Merged
merged 11 commits into from
Apr 17, 2020
Merged

Add ResourceID to VirtualNetwork #952

merged 11 commits into from
Apr 17, 2020

Conversation

melonrush13
Copy link
Contributor

Closes #910

What this PR does / why we need it:

  • Adds resourceid to the status field for virtual network.
  • Modifies Get func in Virtual Network(VNetExists) to return a vnet and err instead of a bool and err so we can grab the vnet.ID

Special notes for your reviewer:

  • Create a virtual network
  • Check the output and confirm the resource ID is there

Should look like:

status:
  message: successfully provisioned
  provisioned: true
  requested: "2020-04-15T20:14:48Z"
  resourceId: /subscriptions/7060bca0-7a3c-44bd-b54c-4bb1e9facfac/resourceGroups/resourcegroup-azure-operators-mel/providers/Microsoft.Network/virtualNetworks/virtualnetwork-sample-2

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@melonrush13
Copy link
Contributor Author

Fixed @frodopwns ! Thanks for the comments :)

frodopwns
frodopwns approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melonrush13 melonrush13 merged commit bf4decd into Azure:master Apr 17, 2020
@melonrush13 melonrush13 deleted the vnetid branch April 17, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodopwns frodopwns frodopwns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Add ResourceID to VirtualNetwork
2 participants
@melonrush13 @frodopwns