Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#issue918#addVnetToCosmosDB #963

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Conversation

buhongw7583c
Copy link
Contributor

@buhongw7583c buhongw7583c commented Apr 20, 2020

Closes #918

What this PR does / why we need it:
Support vnet to cosmosDB.
Special notes for your reviewer:
Modify the cosmosdb sample yaml file to add the vnet information. Remember to set isVirtualNetworkFilterEnabled to true to enable the vent function.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@frodopwns frodopwns requested a review from jpflueger April 20, 2020 16:33
Copy link
Contributor

@jpflueger jpflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@buhongw7583c buhongw7583c merged commit 76113ef into Azure:master Apr 21, 2020
@buhongw7583c buhongw7583c deleted the issue#918 branch April 21, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: CosmosDB: configure VNet rules
2 participants