Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test cleanup] Cleanup suite_test and use Ensure functions #971

Merged
merged 8 commits into from
Apr 21, 2020
Merged

[Test cleanup] Cleanup suite_test and use Ensure functions #971

merged 8 commits into from
Apr 21, 2020

Conversation

jananivMS
Copy link
Contributor

@jananivMS jananivMS commented Apr 21, 2020 •
edited
Loading

Closes #445
Also addresses part of #677

What this PR does / why we need it:

  • We were creating Eventhub namespaces, eventhubs, storage account and blob container in the suite_test file even if we werent running these tests. This PR moves these to the individual tests and also consolidates tests to save time and avoid redundancy (without removing any existing test case)
  • There was also a validation issue in the storageaccount types file that was causing the test to fail, fixed that.
  • This PR also moves all the tests to use Ensure* functions for consistency

Special notes for your reviewer:
Run tests with different tags to make sure there aren't any issues

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@jananivMS jananivMS mentioned this pull request Apr 21, 2020
Closed
3 tasks
@jananivMS jananivMS changed the title WIP: Cleanup suite_test and use Ensure functions [Test cleanup] Cleanup suite_test and use Ensure functions Apr 21, 2020
@frodopwns frodopwns self-requested a review April 21, 2020 20:23
frodopwns
frodopwns approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jananivMS jananivMS merged commit 9e6909c into Azure:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodopwns frodopwns frodopwns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jananivMS @frodopwns