Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy setting not used in Transient mode #1700

Closed
marcelk-workstreampeople-com opened this issue Oct 24, 2022 · 0 comments · Fixed by #1708
Closed

Proxy setting not used in Transient mode #1700

marcelk-workstreampeople-com opened this issue Oct 24, 2022 · 0 comments · Fixed by #1708
Assignees
@Y-Sindo
Labels
bug Something isn't working

Comments

@marcelk-workstreampeople-com
Copy link

marcelk-workstreampeople-com commented Oct 24, 2022 •
edited
Loading

Describe the bug

When I try to connect a ServiceManager to the BackPlane using a Proxy (ServiceManagerOptions.Proxy setting) with a Transient transport type, it seems like the Proxy is not used. When I try to connect using a Persistant connection the Proxy setting is indeed used.

To Reproduce

 var serviceManager = new ServiceManagerBuilder().WithOptions(option =>
                {
                    option.ConnectionString = _connectionString;
                    option.ServiceTransportType = ServiceTransportType.Transient;
                    option.Proxy = new WebProxy(new Uri("http://localhost:8888")); // fiddler
                })

Further technical details

  • Azure SignalR SDK / 1.18.3
  • .net 6
  • SignalR Client SDK version 1.18.3
@Y-Sindo Y-Sindo added the bug Something isn't working label Nov 3, 2022
@Y-Sindo Y-Sindo self-assigned this Nov 3, 2022
@Y-Sindo Y-Sindo mentioned this issue Nov 4, 2022
Merged
Y-Sindo added a commit that referenced this issue Nov 7, 2022
@Y-Sindo
Fix proxy not applied to serverless transient mode (#1708)
b2670fe 
Fix #1700
JialinXin added a commit that referenced this issue Nov 8, 2022
@JialinXin @vicancy
@kevinguo-ed @Y-Sindo @xingsy97 @terencefan
Release v1.19.0 (#1712)
3470d1f 
* Update Actions to use dotnet build (#1663)

* Update windows.yml

* Add configurable options (#1654)

* Update CI to enable net7.0 preview builds (#1677)

* Support net7.0

* update osx/ubuntu.

* revert common package upgrade.

* update build-source guide and revert net7.0 in src.

* Add OrTimeout()

* Fix build warnings and add net6 samples (#1676)

* Fix build warning

* Update docs

* Fix build failure

* Fix test failure

* Fix vlunerability issue (#1678)

* Fix vlunerability issue

* fix filters

* fix filters

* Update use-signalr-service.md (#1683)

* Change emulator to net6.0 (#1682)

* Change emulator to net6.0

* Fix test

* Add filter property...... (#1686)

* Add filter

* Add multiPayload case

* Adding comments

* Update management-sdk-guide.md (#1689)

Improve a confusing statement. The original statement can also be interpreted as this SDK only supports SignalR clients based on ASP.NET Core C#, which confuses users. #1688

* Expose InstanceId in ClientConnectionContext (#1692)

* Fix `HubConnectionContext.UserIdentifier` is null when negotiation with Management SDK (#1691)

When clients negotiatie with Management SDK and connect to SignalR server, IUserIdProvider might not work as the user ID is set directly in the Management SDK.

To make HubConnectionContext.UserIdentifier have the valid value in this case, we should set it before the server accesses it. HubLifetimeManager{THub}.OnConnectedAsync(HubConnectionContext) is the only chance we can set the value. However, we cannot access the Constants.ClaimType.UserId as ASRS system claims are trimmed there. HubConnectionContext.Features is the place where we can store the user Id.

The following code is the injection point.
https://github.com/dotnet/aspnetcore/blob/v6.0.9/src/SignalR/server/Core/src/HubConnectionHandler.cs#L132-L141

Fixes #1679

* Add ClientInvocationManager (#1684)

* add ClientInvocationManager

* update CallerClientResultsManager (#1697)

add `TryCompleteResult` for `ErrorCompletionMessage`

* Implement close on client authentication expiration (#1699)

* Add spec for client-invocation. (#1701)

* Add spec for client-invocation.

* minor update direction for ErrorCompletionMessage

* Add client Invocation implementation and UTs (#1687)

* Add client Invocation implementation and UTs

* [ClientInvocation] Fix cleanup in caller case. (#1702)

* Fix cleanup in caller case.

* fix UT.

* Update src/Microsoft.Azure.SignalR.Common/ClientInvocation/IClientInvocationManager.cs

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>

* Add ClientResultSample (#1703)

* Add ClientResultSample

* Move file

* minor update.

* minor update README.

* show server/service ex.message

* Add Broadcast method and update README

* Fix proxy not applied to serverless transient mode (#1708)

Fix #1700

* silent IDE0090 check (#1709)

* reduce retry interval when auth failed (#1451)

* Clean up dependencies. (#1711)

* Update dep to GA version.

* clean up dependencies

* clean management.

* fix test dep.

Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
Co-authored-by: Kevin Guo <105208143+kevinguo-ed@users.noreply.github.com>
Co-authored-by: yzt <zityang@microsoft.com>
Co-authored-by: Eric Xing <87063252+xingsy97@users.noreply.github.com>
Co-authored-by: Terence Fan <stdrickforce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Y-Sindo Y-Sindo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix proxy not applied to serverless transient mode Y-Sindo/azure-signalr
2 participants
@Y-Sindo @marcelk-workstreampeople-com