remove references to System.IdentityModel.Tokens.Jwt in JWT token generation
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicancy
reviewed
Aug 17, 2022
Directory.Build.props
Outdated
| @@ -79,7 +79,7 @@ | |||
| <SignedPackageFile Include="$(PublishDir)Newtonsoft.Json.dll" Certificate="$(AssemblySigningCertName)" Visible="false" /> | |||
| <SignedPackageFile Include="$(PublishDir)System.IO.Pipelines.dll" Certificate="$(AssemblySigningCertName)" Visible="false" /> | |||
| <SignedPackageFile Include="$(PublishDir)System.IdentityModel.Tokens.Jwt.dll" Certificate="$(AssemblySigningCertName)" Visible="false" /> | |||
| <SignedPackageFile Include="$(PublishDir)System.Text.Encodings.Web.dll" Certificate="$(AssemblySigningCertName)" Visible="false" /> | |||
| <SignedPackageFile Include="$(PublishDir)System.Text.Encodings.Web.dll" Certificate="$(AssemblySigningCertName)" Visible="false" /> | |||
There was a problem hiding this comment.
This file is no longer in Files changed list
| @@ -20,9 +18,9 @@ | |||
|
|
|||
| namespace Microsoft.Azure.SignalR | |||
| { | |||
| internal class JwtSecurityTokenHandlerSignalR : JwtSecurityTokenHandler | |||
| internal class JwtSecurityTokenHandlerSignalR | |||
There was a problem hiding this comment.
naming SignalRJwtSecurityTokenHandler
| @@ -57,8 +55,9 @@ internal class JwtSecurityTokenHandlerSignalR : JwtSecurityTokenHandler | |||
| JwtPayload payload = new JwtPayload(issuer, audience, (subject == null ? null : OutboundClaimTypeTransform(subject.Claims)), notBefore, expires, issuedAt); | |||
| JwtHeader header = new JwtHeader(kid, algorithm); | |||
|
|
|||
| if (subject?.Actor != null) | |||
| payload.AddClaim(new Claim(JwtRegisteredClaimNames.Actort, CreateActorValue(subject.Actor))); | |||
| // Because subject.Actor is always null, we skip this | |||
There was a problem hiding this comment.
remove code, and merge the comment with the class comment above
vicancy
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes