Fix DI issue in EndpointRouterDecorator #1845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change to use a new ctor to avoid binary breaking change |
vicancy
reviewed
Oct 17, 2023
| @@ -15,6 +16,11 @@ public EndpointRouterDecorator(IEndpointRouter router = null) | |||
| _inner = router ?? new DefaultEndpointRouter(null); | |||
| } | |||
|
|
|||
| public EndpointRouterDecorator(IEndpointRouter router = null, IOptions<ServiceOptions> options = null) | |||
There was a problem hiding this comment.
change to ctors without default value?
public EndpointRouterDecorator()
public EndpointRouterDecorator(IEndpointRouter router)
public EndpointRouterDecorator(IEndpointRouter router, IOptions<ServiceOptions> options)
|
Remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
The
EndpointRouterDecoratoris injected before theDefaultEndpointRouterin our example. To avoid the DI issue when customer partially override theEndpointRouterDecorator, DIoptionstoo.