chore: update msal-go example to use azidentity and azsecrets sdk #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
sdk/azsecrets/azidentity
branch
from
0bb81d2
to
feb2522
Compare
|
@aramase Any idea on why this is failing? I tried your exampel but I only get "no token found" in a error |
aramase
force-pushed
the
sdk/azsecrets/azidentity
branch
2 times, most recently
from
ea3cc1c
to
1527b3c
Compare
enj
reviewed
Nov 22, 2022
| @@ -4,83 +4,72 @@ import ( | |||
| "context" | |||
There was a problem hiding this comment.
This example is built and used as part of our e2e tests (ref: https://github.com/Azure/azure-workload-identity/blob/main/test/e2e/token_exchange.go)
aramase
force-pushed
the
sdk/azsecrets/azidentity
branch
from
1527b3c
to
27c823b
Compare
aramase
force-pushed
the
sdk/azsecrets/azidentity
branch
from
27c823b
to
4b2ca82
Compare
enj
approved these changes
Nov 22, 2022
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
sdk/azsecrets/azidentity
branch
from
4b2ca82
to
b1a2be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: