This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Changing the APT test logic in install.sh #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing pre-apt test to use ID_LIKE instead of just ID, potentially enabling installation in more Debian-derived distributions
Adding a DISTRIB_ID check to converge in the case of Debian upstream
Closed
|
Hi folks, any updates on this one? Currently blocking upgrading Azure Cloud Shell to a newer base image. If this can't be resolved we will have to drop batch-shipyard because we can't stay on current image indefinitely. |
|
@edyoung thanks for following up - is there a proposed drop date? |
|
@alfpark I'm still trying to fix a couple other issues but I would like to release this month or early next. |
edyoung
approved these changes
Oct 6, 2020
| @@ -157,7 +158,7 @@ echo "Detected OS: $DISTRIB_ID $DISTRIB_RELEASE" | |||
|
|
|||
There was a problem hiding this comment.
you might want to echo $DISTRIB_LIKE as well
alfpark
force-pushed
the
develop
branch
8 times, most recently
from
5681bfb
to
dc41a19
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing pre-apt test to use ID_LIKE instead of just ID, potentially enabling installation in more Debian-derived distributions. This is related to #355.
Pull Request Checklist
masterif it includes no features (open againstdevelopotherwise)Description
This was successfully tested in a Debian-derived distro that has an arbitrary ID but where /etc/os-release also had an ID_LIKE pointing to Debian. It should also be tested in Debian and Ubuntu proper (across all supported releases), noting that Ubuntu uses ID_LIKE as well.