Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Test python system executable before nodeprep use #364

Closed

Conversation

emattiza
Copy link

Because of some operating systems choice to deprecate a named system
executable of just python, this will test for a suitable python3 if
available, otherwise revert to the prior standard command

Issues: #363

Pull Request Checklist

  • Review the contributing guidelines
  • Outstanding issue linked, if applicable
  • PR should only be opened against master if it includes no features (open against develop otherwise)
  • Commit messages should conform to good style practices
  • PR should pass all checks and have no conflicts

Description

Amends the python call to point to python3 if available, else defaults to python. Eliminates command not found error

Because of some operating systems choice to deprecate a named system
executable of just python, this will test for a suitable python3 if
available, otherwise revert to the prior stated command
@emattiza emattiza force-pushed the emattiza-patch_nodeprep_sh-1 branch from c20d827 to 0e139ec Compare March 31, 2021 18:56
@alfpark alfpark force-pushed the develop branch 8 times, most recently from 5681bfb to dc41a19 Compare April 26, 2021 20:55
@alfpark
Copy link
Collaborator

alfpark commented Oct 1, 2021

Thanks, this was a missed line in using the stored python invocation and will be fixed.

@alfpark alfpark closed this Oct 1, 2021
@emattiza emattiza deleted the emattiza-patch_nodeprep_sh-1 branch October 6, 2021 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants