Generate modules metadata #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains changes to the CI definitions. Reviews from @Azure/bicep-admins are needed. |
bhsubra
changed the title
shenglol
reviewed
Feb 1, 2023
shenglol
reviewed
Feb 1, 2023
| * @param {string} dir | ||
| */ | ||
| function getSubdirNames(dir) { | ||
| const fs = require("fs"); |
There was a problem hiding this comment.
Should fs remain a parameter and be passed from the caller?
There was a problem hiding this comment.
Updated here:
20d412d
Thanks!
shenglol
reviewed
Feb 1, 2023
Comment on lines
+3
to
+16
| workflow_call: | ||
| secrets: | ||
| # Secrets must be passed from the caller workflow explicitly. | ||
| CLIENT_ID: | ||
| required: true | ||
| TENANT_ID: | ||
| required: true | ||
| SUBSCRIPTION_ID: | ||
| required: true | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| id-token: write | ||
| contents: read |
There was a problem hiding this comment.
Are the secrets needed? If not, we should remove them.
There was a problem hiding this comment.
Yes, I'll be sending out a follow up PR to login to azure and write the modules metadata to storage account container. Let me know if you want me to remove it here and include it in other PR.
There was a problem hiding this comment.
No, in that case we can leave them as is.
shenglol
approved these changes
Feb 1, 2023
bhsubra
deleted the
dev/bhsubra/WriteModulesMetadataToStorageAccountContainer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR include:
Verified the changes in dogfood via:
bhsubra#1