feat: add support for oidc azure/login params #2523
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for OIDC authentication to the azure/login@v2 workflow and avoid client secrets. Compatible with actions configurations using either OIDC or AZURE_CREDNTIALS approach.
creds
parameter is ignored if client-id, subscription-id, or tenant-id are also specified. See https://github.com/marketplace/actions/azure-login#credsTesting evidence
Old approach:
After setting up a federated credential on the App Registration and adding AZURE_CLIENT_ID, AZURE_SUBSCRIPTION_ID, and AZURE_TENANT_ID workflow secrets:
(when AZURE_CREDNTIALS exists)
(when AZURE_CREDENTIALS does not exist)
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.