Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.TimeSeriesInsights type generation being skipped #804

Closed
jeskew opened this issue May 13, 2022 · 2 comments
Closed

Microsoft.TimeSeriesInsights type generation being skipped #804

jeskew opened this issue May 13, 2022 · 2 comments
Assignees

Comments

@jeskew
Copy link
Contributor

jeskew commented May 13, 2022

Type generation for models under the timeseriesinsights path has been skipped for about a year:

image

Autorest/modelerfour is reporting a DuplicateParentReference error with the message The schema ResourceProperties is already referenced in an allOf by EnvironmentResourceProperties (or one of its parents).

@jeskew
Copy link
Contributor Author

jeskew commented May 13, 2022

There are a couple schemata I was able to find that declare both ResourceProperties and EnvironmentResourceProperties to be direct parents, so I submitted a PR to update the swagger files and am waiting to hear back.

As far as I know, the same shape appearing multiple times in an ancestor tree is not expressly forbidden in JSON schema, so the right thing to do here might be to instead relax this rule in Autorest.

@jeskew jeskew self-assigned this May 26, 2022
@jeskew
Copy link
Contributor Author

jeskew commented Jun 2, 2022

Changes to the service model were merged today, and type generation for timeseriesinsights is working again

@jeskew jeskew closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant