Corect duplicate parent references in timeseriesinsights@2018-08-15-preview #19010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jeskew Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1470 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1951 |
|
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: kind, path: $.EnvironmentCreateOrUpdateParameters.properties.kind Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1827 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L54 |
|
The response schema of operations API '/providers/Microsoft.TimeSeriesInsights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L37 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L123 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1086 |
|
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1113 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1141 |
|
The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1162 |
|
The schema 'ResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1190 |
|
The schema 'CreateOrUpdateTrackedResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1311 |
|
The schema 'EnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1334 |
|
The schema 'StandardEnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1365 |
|
The schema 'LongTermEnvironmentCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1383 |
|
The schema 'EnvironmentListResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1450 |
|
The schema 'StandardEnvironmentResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1490 |
|
The schema 'LongTermEnvironmentResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1508 |
|
The schema 'StandardEnvironmentCreationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1526 |
|
The schema 'LongTermEnvironmentCreationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1558 |
|
The schema 'EnvironmentResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1583 |
|
The schema 'LongTermEnvironmentResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1622 |
|
The schema 'TimeSeriesIdProperty' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1690 |
|
The schema 'EventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1824 |
|
The schema 'EventHubEventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1854 |
|
The schema 'IoTHubEventSourceCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1872 |
|
The schema 'EventSourceListResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1935 |
|
The schema 'EventHubEventSourceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1970 |
|
The schema 'IoTHubEventSourceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L1988 |
|
The schema 'EventSourceCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json#L2006 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @jeskew, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
The breaking change warnings are a false positive; both updated shapes list both |
This was referenced May 10, 2022
|
@changlong-liu gentle ping on this. This PR fixes a Swagger bug that is preventing Autorest-based tools from being regenerated. There is no change to the underlying API model. |
|
Hi @jeskew , would you please take a look at the semanticValidation failure https://github.com/Azure/azure-rest-api-specs/pull/19010/checks?check_run_id=6377274770 |
|
Based on the example provided for the operation that caused the semanticValidation failure, I think the right remediation may be to remove the @Azure/time-series-insights could someone from the service team take a look? I'll update this PR to reflect the change described above. |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
changlong-liu
approved these changes
May 30, 2022
|
Hi @jeskew , would you like to merge this PR now? |
Ideally, I'd like to get approval from the service team that owns the swagger file (@Azure/time-series-insights). |
|
LGTM - removing ResourceProperties parent ref, and unneeded x-ms-discriminator value in update params. Since it is RP swagger, I would suggest that @sandshadow signs off. FYI - TSI will no longer be supported after March 2025, see https://aka.ms/tsi2adx |
k-rush
approved these changes
Jun 1, 2022
| @@ -1908,7 +1902,6 @@ | |||
| }, | |||
| "EventHubEventSourceUpdateParameters": { | |||
| "type": "object", | |||
| "x-ms-discriminator-value": "Microsoft.EventHub", | |||
There was a problem hiding this comment.
I was wary of this change, but this should be ok. The parent EventSourceUpdateParameters doesn't have a descriminator field, and we indeed do not support changing the event source kind via PATCH.
Comment on lines
-1615
to
-1617
| }, | ||
| { | ||
| "$ref": "#/definitions/ResourceProperties" |
|
Thanks for taking a look, @dmdenmsft and @k-rush! @changlong-liu please go ahead and merge. Thanks for reviewing! |
jeskew
deleted the
jeskew/correct-duplicate-parent-reference-in-timeseriesinsights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add a changelog entry for this PR by answering the following questions:
The 2018-08-15-preview version of TimeSeriesInsights is raising DuplicateParentReference errors in the ModelerFour Autorest plugin, which is preventing Bicep from regenerating code for this API.
N/A
N/A
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.