-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of azure next link #778
Remove use of azure next link #778
Conversation
🦋 Changeset detectedLatest commit: b4d04f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tadelesh Does TCGC at present handle the 2 nextLink
annotation the same way?
If yes, I guess we can remove it here.
@AlitzelMendez I assume this PR depends on the merge on your typespec-azure-core PR? Azure/typespec-azure#1886
yes. there should be no impact for tcgc result as long as |
Got it. So this PR would be read-to-merge after the PR to typespec-azure get merged. |
I would prefer if we can merge this first so I can have a green build in my other pull request, as we are running the E2E it fails as we are removing something that is still use in here @markcowl could you please take a look? 😄 |
@tadelesh @weidongxu-microsoft Because we verify cadl-ranch as part of ci checks in typespec-azure, this PR has to be merged before removing the decorator there. Can one of you or the other code owners approve this? |
approved and merged |
Fixing breaking change caused by: Azure/typespec-azure#1886
Cadl Ranch Contribution Checklist:
@scenario
names. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDoc
s for extra scenario description and to tell people how to pass my mock api check.