Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of azure next link #778

Merged

Conversation

AlitzelMendez
Copy link
Member

@AlitzelMendez AlitzelMendez commented Dec 4, 2024

Fixing breaking change caused by: Azure/typespec-azure#1886

Cadl Ranch Contribution Checklist:

  • I have written a scenario spec
  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
  • I have written a mock API
  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: b4d04f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@azure-tools/cadl-ranch-specs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tadelesh Does TCGC at present handle the 2 nextLink annotation the same way?
If yes, I guess we can remove it here.

@AlitzelMendez I assume this PR depends on the merge on your typespec-azure-core PR? Azure/typespec-azure#1886

@tadelesh
Copy link
Member

tadelesh commented Dec 4, 2024

@tadelesh Does TCGC at present handle the 2 nextLink annotation the same way? If yes, I guess we can remove it here.

@AlitzelMendez I assume this PR depends on the merge on your typespec-azure-core PR? Azure/typespec-azure#1886

yes. there should be no impact for tcgc result as long as getPagedResult in core give the right result.

@weidongxu-microsoft
Copy link
Member

Got it. So this PR would be read-to-merge after the PR to typespec-azure get merged.

@AlitzelMendez
Copy link
Member Author

@tadelesh Does TCGC at present handle the 2 nextLink annotation the same way? If yes, I guess we can remove it here.

@AlitzelMendez I assume this PR depends on the merge on your typespec-azure-core PR? Azure/typespec-azure#1886

I would prefer if we can merge this first so I can have a green build in my other pull request, as we are running the E2E it fails as we are removing something that is still use in here

@markcowl could you please take a look? 😄

@markcowl
Copy link
Member

markcowl commented Dec 5, 2024

@tadelesh @weidongxu-microsoft Because we verify cadl-ranch as part of ci checks in typespec-azure, this PR has to be merged before removing the decorator there. Can one of you or the other code owners approve this?

@weidongxu-microsoft weidongxu-microsoft merged commit cc8bbf7 into Azure:main Dec 6, 2024
9 checks passed
@weidongxu-microsoft
Copy link
Member

approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants