Write Test Case For Azure cli Action #48

PankajGovindRao · 2021-08-09T12:59:46Z

Test Case For Azure cli Action

ghost · 2021-08-09T12:59:59Z

All CLA requirements met.

t-dedah · 2021-08-09T13:05:00Z

src/main.ts

@@ -21,15 +22,18 @@ const run = async () => {
        }

        let inlineScript: string = core.getInput('inlineScript', { required: true });
-        let azcliversion: string = core.getInput('azcliversion', { required: true }).trim().toLowerCase();
-
+        let azcliversion: string = core.getInput('azcliversion', { required: true });


Add .trim().toLowerCase() back

Added .trim().toLowerCase()

t-dedah · 2021-08-09T13:05:10Z

src/main.ts

        if (!(await checkIfValidCLIVersion(azcliversion))) {
+            console.log("INVALID VERSION")


remove this console.log

t-dedah · 2021-08-09T13:05:55Z

src/main.ts

            core.setFailed('Please enter a valid azure cli version. \nSee available versions: https://github.com/Azure/azure-cli/releases.');
+            throw new Error('Please enter a valid azure cli version. \nSee available versions: https://github.com/Azure/azure-cli/releases.')
            return;


remove return

t-dedah · 2021-08-09T13:06:15Z

src/main.ts

            return;
        }

        if (!inlineScript.trim()) {
            core.setFailed('Please enter a valid script.');
+            throw new Error('Please enter a valid script.')
            return;


remove return

t-dedah · 2021-08-16T05:54:45Z

.github/workflows/ci-workflow.yml

@@ -0,0 +1,47 @@
+name: ci-workflow
+on:


Replace on with this -

on: push: schedule: - cron: '0 */3 * * *'

t-dedah · 2021-08-16T05:55:27Z

.github/workflows/ci-workflow.yml

+          INPUT_INLINESCRIPT: " "
+          EXPECTED_TO: fail
+        run: ts-node test/main.test.ts
+


Add post status action at the end

- name: Post to slack on failure if: failure() uses: 8398a7/action-slack@v3.9.1 with: status: ${{ job.status }} fields: repo,message,author,action,ref,workflow env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

github-actions · 2021-08-21T09:01:00Z

This PR is idle because it has been open for 14 days with no activity.

* Updated Readme for Azure CLI actions (#29) * Update README.md * Update README.md Co-authored-by: Usha N <n-usha@github.com> * Add changes * Added add-label workflow (#41) * Added add-label workflow * Updated default label worlkflow for health dashboard * Reduced time * Added issue template for health dashboard (#42) * Added issue template for health dashboard * Added assignees * Add 'getting help' section to point customers to Azure CLI Repo for help (#50) Signed-off-by: James Casey <james.casey@microsoft.com> * Write Test Case For Azure cli Action (#48) * Create main.test.ts * Create ci-workflow.yml * Update main.ts * Update ci-workflow.yml * Update main.ts * Update ci-workflow.yml * Update ci-workflow.yml * Resolved multiple README issues (#51) * Resolved multiple issues * revert * Changed default for azcliversion. (#57) * Added restrictLatestToAgent * typo * required set to false * Changed default to agent az cli version * deleted lib files * Resolved comments * Add changes * Update package.json * Update package-lock.json * Upgrade version (#59) * Revert "Update package-lock.json" This reverts commit 5633362. * Revert "Update package.json" This reverts commit f4b36bb. * Upgrade version in packkage.json Co-authored-by: Zainudeen V K <zainuvk@github.com> Co-authored-by: Usha N <n-usha@github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: James Casey <james.casey@microsoft.com> Co-authored-by: PankajGovindRao <84085346+PankajGovindRao@users.noreply.github.com>

PankajGovindRao added 4 commits August 9, 2021 18:18

Create main.test.ts

70a2786

Create ci-workflow.yml

2e6ad25

Update main.ts

1406d17

Update ci-workflow.yml

f44023b

t-dedah suggested changes Aug 9, 2021

View reviewed changes

t-dedah requested review from bishal-pdMSFT and tejasd1990 August 9, 2021 13:07

Update main.ts

1e73842

PankajGovindRao requested a review from t-dedah August 11, 2021 04:57

t-dedah reviewed Aug 16, 2021

View reviewed changes

Update ci-workflow.yml

44a2a62

PankajGovindRao requested a review from t-dedah August 16, 2021 06:40

github-actions bot added the idle Inactive for 14 days label Aug 21, 2021

Update ci-workflow.yml

bf01cb4

t-dedah approved these changes Aug 23, 2021

View reviewed changes

t-dedah merged commit dbebf94 into Azure:master Aug 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write Test Case For Azure cli Action #48

Write Test Case For Azure cli Action #48

PankajGovindRao commented Aug 9, 2021

ghost commented Aug 9, 2021 •

edited by ghost

Loading

t-dedah Aug 9, 2021

PankajGovindRao Aug 9, 2021

t-dedah Aug 9, 2021

PankajGovindRao Aug 9, 2021

t-dedah Aug 9, 2021

PankajGovindRao Aug 9, 2021

t-dedah Aug 9, 2021

PankajGovindRao Aug 9, 2021

t-dedah Aug 16, 2021

PankajGovindRao Aug 16, 2021

t-dedah Aug 16, 2021

PankajGovindRao Aug 16, 2021

github-actions bot commented Aug 21, 2021

		if (!(await checkIfValidCLIVersion(azcliversion))) {
		console.log("INVALID VERSION")

Write Test Case For Azure cli Action #48

Write Test Case For Azure cli Action #48

Conversation

PankajGovindRao commented Aug 9, 2021

ghost commented Aug 9, 2021 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2021

ghost commented Aug 9, 2021 •

edited by ghost

Loading