Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename helm imageKey to image to match starter workflows #176

Merged
merged 7 commits into from
Feb 10, 2023
+40 −21
Merged

rename helm imageKey to image to match starter workflows #176

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c052c3a
rename imageKey to image to match starter workflows
davidgamero Feb 2, 2023
06f04f5
Merge branch 'main' into davidgamero/helm-match-starter-workflows
davidgamero Feb 2, 2023
57fff6e
Merge branch 'main' into davidgamero/helm-match-starter-workflows
davidgamero Feb 2, 2023
3fe0fd3
Merge branch 'main' into davidgamero/helm-match-starter-workflows
davidgamero Feb 3, 2023
be9e1cc
add imagetag variable
davidgamero Feb 6, 2023
39fe615
Merge branch 'main' into davidgamero/helm-match-starter-workflows
davidgamero Feb 9, 2023
663794a
add imagetag as a promptless variable
davidgamero Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/deployments/helm/charts/production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
imageKey:
image:
repository: "{{APPNAME}}"
pullPolicy: IfNotPresent
tag: "latest"
Expand Down
4 changes: 2 additions & 2 deletions template/deployments/helm/charts/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.imageKey.repository }}"
imagePullPolicy: {{ .Values.imageKey.pullPolicy }}
image: "{{ .Values.image.repository }}"
davidgamero marked this conversation as resolved.
Show resolved Hide resolved
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: http
containerPort: {{ .Values.containerPort }}
Expand Down
2 changes: 1 addition & 1 deletion template/deployments/helm/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace: {{NAMESPACE}}

containerPort: {{PORT}}

imageKey:
image:
davidgamero marked this conversation as resolved.
Show resolved Hide resolved
repository: {{IMAGENAME}}
pullPolicy: IfNotPresent

Expand Down
2 changes: 1 addition & 1 deletion test/skaffold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ deploy:
- name: my-chart
chartPath: charts
artifactOverrides:
imageKey: my-app
image: my-app
imageStrategy:
helm: {}
2 changes: 1 addition & 1 deletion test/templates/helm/charts/production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
imageKey:
image:
repository: "test"
pullPolicy: IfNotPresent
tag: "latest"
Expand Down
2 changes: 1 addition & 1 deletion test/templates/helm/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ replicaCount: 1

containerPort: 8080

imageKey:
image:
repository: test
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
Expand Down
2 changes: 1 addition & 1 deletion test/templates/helm_prod_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
imageKey:
image:
repository: "prodImage"
pullPolicy: IfNotPresent
tag: "latest"