Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update actions from deprecated node12/14 #196

Merged
merged 6 commits into from
Apr 4, 2023
Merged

update actions from deprecated node12/14 #196

merged 6 commits into from
Apr 4, 2023

Conversation

davidgamero
Copy link
Collaborator

Description

Several actions are deprecated and we need to bump these versions

Type of change

  • Dependency bump

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero marked this pull request as ready for review March 16, 2023 20:54
Tatsinnit
Tatsinnit approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉☕️

@Tatsinnit Tatsinnit added the enhancement New feature or request label Apr 2, 2023
@davidgamero davidgamero enabled auto-merge (squash) April 4, 2023 17:15
jaiveerk
jaiveerk approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit facaf10 into Azure:main Apr 4, 2023
@davidgamero davidgamero mentioned this pull request Apr 10, 2023
Merged
aamgayle pushed a commit that referenced this pull request Apr 12, 2023
@davidgamero @bosesuneha @aamgayle
update actions from deprecated node12/14 (#196)
e332d38 
Co-authored-by: bosesuneha <123775811+bosesuneha@users.noreply.github.com>
aamgayle pushed a commit that referenced this pull request Apr 12, 2023
@davidgamero @bosesuneha @aamgayle
update actions from deprecated node12/14 (#196)
72fba0d 
Co-authored-by: bosesuneha <123775811+bosesuneha@users.noreply.github.com>
@davidgamero davidgamero deleted the davidgamero/bump-actions branch April 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@jaiveerk jaiveerk jaiveerk approved these changes

Assignees

@davidgamero davidgamero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidgamero @Tatsinnit @jaiveerk @bosesuneha