-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to detect jre version from build.gradle #214
Conversation
adaa52e
to
958b352
Compare
7f06e24
to
86dedad
Compare
6ae9773
to
6c0d174
Compare
597106e
to
e1bb7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊🙏❤️☕️🚀 thank you so much for this, al little fyi to @davidgamero for eyes on this.
9ce2e0d
to
843328e
Compare
☕️🥷 please note- seems like there is 404 when downloading draft cli, integration test might need some re-check here: (complete hunch and it should be tested is that might be os-arch for max for that latest more is not there. Thanks heaps 🙏 💡although I am not able to see and direct relation.
|
@Tatsinnit Thanks for pointing it out, seems like it is intermittent, it passed previously and client version is not null , weird. I will check and fix it in another PR :) https://github.com/Azure/draft/actions/runs/5223305355/jobs/9429991236 |
Closing this as it is taken care in another PR 218 |
Description
This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.
Fixes # (issue)
Feature # (details)
This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: