Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to detect jre version from build.gradle #214

Closed
wants to merge 35 commits into from

Conversation

hsubramanianaks
Copy link
Contributor

@hsubramanianaks hsubramanianaks commented Jun 2, 2023

Description

This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.

Fixes # (issue)
Feature # (details)
This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Unit test
  • Gradle wrapper sample project

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hsubramanianaks hsubramanianaks marked this pull request as ready for review June 8, 2023 17:33
cmd/create.go Outdated Show resolved Hide resolved
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🙏❤️☕️🚀 thank you so much for this, al little fyi to @davidgamero for eyes on this.

cmd/create.go Show resolved Hide resolved
cmd/create.go Outdated Show resolved Hide resolved
cmd/create.go Outdated Show resolved Hide resolved
@Tatsinnit Tatsinnit requested a review from davidgamero June 9, 2023 09:39
@Tatsinnit Tatsinnit added the enhancement New feature or request label Jun 9, 2023
@Tatsinnit
Copy link
Member

Tatsinnit commented Jun 9, 2023

☕️🥷 please note- seems like there is 404 when downloading draft cli, integration test might need some re-check here: (complete hunch and it should be tested is that might be os-arch for max for that latest more is not there. Thanks heaps 🙏

💡although I am not able to see and direct relation.

IMG_5253

@hsubramanianaks
Copy link
Contributor Author

☕️🥷 please note- seems like there is 404 when downloading draft cli, integration test might need some re-check here: (complete hunch and it should be tested is that might be os-arch for max for that latest more is not there. Thanks heaps 🙏

💡although I am not able to see and direct relation.

IMG_5253

@Tatsinnit Thanks for pointing it out, seems like it is intermittent, it passed previously and client version is not null , weird. I will check and fix it in another PR :)

https://github.com/Azure/draft/actions/runs/5223305355/jobs/9429991236

cmd/create.go Outdated Show resolved Hide resolved
@hsubramanianaks
Copy link
Contributor Author

Closing this as it is taken care in another PR 218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants