Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry releases to get tag name #219

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

hsubramanianaks
Copy link
Contributor

@hsubramanianaks hsubramanianaks commented Jun 30, 2023

Description

This PR is to fix the issue where GH action for install script fails intermittent, introducing retry will retry getting the tag name from releases.

Root cause: due to github rate limiting for unauthenticated requests , it is failing with below error. Fixing this with authenticated requests using github token from env variable.

image

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Manual Test via GH actions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a much needed change!

@hsubramanianaks hsubramanianaks force-pushed the fix-draft-cli-version branch 2 times, most recently from c9258f2 to a9ac95d Compare June 30, 2023 15:17
@hsubramanianaks hsubramanianaks added the bug Something isn't working label Jun 30, 2023
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsubramanianaks hsubramanianaks force-pushed the fix-draft-cli-version branch from d9b3980 to 039bc95 Compare June 30, 2023 20:59
@hsubramanianaks hsubramanianaks force-pushed the fix-draft-cli-version branch from 178d374 to fc0616c Compare July 6, 2023 15:04
@hsubramanianaks hsubramanianaks force-pushed the fix-draft-cli-version branch from afad0a2 to 7d4c891 Compare July 6, 2023 15:07
Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger tests

@hsubramanianaks hsubramanianaks merged commit b143ed2 into Azure:main Jul 6, 2023
@hsubramanianaks hsubramanianaks deleted the fix-draft-cli-version branch July 6, 2023 15:40
@Tatsinnit Tatsinnit mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants