Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for supported flags #220

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

davidgamero
Copy link
Collaborator

Description

update our readme with the list of supported flags for wrapping the draft binary

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@Tatsinnit Tatsinnit added the documentation Improvements or additions to documentation label Jul 3, 2023
Copy link
Contributor

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidgamero looks good. Suggestion/idea - for these readme.md updates do we need to run all the GH actions like integration tests, install script tests ? can we tweak them to run only base on paths changes ex: src/** or tests/** etc.. Thank you.

@davidgamero
Copy link
Collaborator Author

Thats a great point @hsubramanianaks we definitely don't need the tests for readme changes

@Tatsinnit Tatsinnit merged commit 7fd1688 into Azure:main Jul 4, 2023
300 of 301 checks passed
@Tatsinnit Tatsinnit mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants