Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDK calls in tenantID function #258

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

Vidya2606
Copy link
Contributor

@Vidya2606 Vidya2606 commented Mar 20, 2024

Description

Migrating getTenantId function from using the Azure CLI calls to SDK calls from azure-sdk-for-go.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡💡☕️ There are checksum failures https://github.com/Azure/draft/pull/258/checks#step:4:52

Could try this: (not sure if this is known issue and repo owners have other suggestions et. al.)

  • remove go.sum : rm go.sum
  • regenerate go.sum : go mod tidy

@Tatsinnit Tatsinnit added the enhancement New feature or request label Mar 25, 2024
@Tatsinnit Tatsinnit requested a review from a team March 25, 2024 19:34
@Vidya2606

This comment was marked as resolved.

@Vidya2606 Vidya2606 closed this Mar 25, 2024
cmd/setup-gh.go Outdated Show resolved Hide resolved
@Vidya2606 Vidya2606 reopened this Mar 25, 2024
pkg/providers/azure.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
@Vidya2606 Vidya2606 merged commit ff01480 into Azure:main Mar 26, 2024
302 checks passed
@Vidya2606 Vidya2606 deleted the migrate_getTenantId branch July 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants