Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the client interface and unit tests for getTenantID func #262

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Adding the client interface and unit tests for getTenantID func #262

merged 4 commits into from
Apr 12, 2024

Conversation

Vidya2606
Copy link
Contributor

Description

Added the client interface and unit tests for getTenantID func

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

bfoley13
bfoley13 reviewed Apr 4, 2024
View reviewed changes
pkg/providers/azure.go Outdated Show resolved Hide resolved
davidgamero
davidgamero requested changes Apr 12, 2024
View reviewed changes
cmd/setup-gh.go Show resolved Hide resolved
pkg/providers/az_client.go Outdated Show resolved Hide resolved
davidgamero
davidgamero approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tatsinnit
Tatsinnit approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and looks good to me! ☕️🙏❤️

@Tatsinnit Tatsinnit added the enhancement New feature or request label Apr 12, 2024
@Vidya2606 Vidya2606 merged commit d64aa38 into Azure:main Apr 12, 2024
302 checks passed
@Vidya2606 Vidya2606 deleted the tenantIdFunc branch April 12, 2024 21:00
Vidya2606 added a commit to Vidya2606/draft that referenced this pull request Apr 18, 2024
@Vidya2606
Adding the client interface and unit tests for getTenantID func (Azur…
21dd0a0 
…e#262)
@bfoley13 bfoley13 mentioned this pull request May 16, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfoley13 bfoley13 bfoley13 approved these changes

@davidgamero davidgamero davidgamero approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

Assignees

@Vidya2606 Vidya2606

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vidya2606 @bfoley13 @davidgamero @Tatsinnit