Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDK calls for assignSpRole function #272

Merged
merged 8 commits into from
May 15, 2024

Conversation

Vidya2606
Copy link
Contributor

Added SDK calls for assignSpRole function by creating interface and added unit tests.

Screenshot 2024-04-25 at 2 14 37 PM

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except small nit.

pkg/providers/azure.go Outdated Show resolved Hide resolved
cmd/setup-gh.go Outdated Show resolved Hide resolved
cmd/setup-gh.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Outdated Show resolved Hide resolved
pkg/providers/azure_test.go Outdated Show resolved Hide resolved
cmd/setup-gh.go Outdated Show resolved Hide resolved
pkg/providers/az-client.go Show resolved Hide resolved
pkg/providers/azure_test.go Outdated Show resolved Hide resolved
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Vidya2606 Vidya2606 merged commit 8db86bd into Azure:main May 15, 2024
149 checks passed
@Vidya2606 Vidya2606 deleted the assignSpRole branch May 15, 2024 21:13
@bfoley13 bfoley13 mentioned this pull request May 16, 2024
11 tasks
@Vidya2606 Vidya2606 mentioned this pull request May 31, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants