Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few updates to draft #277

Merged
merged 8 commits into from
May 15, 2024
Merged

A few updates to draft #277

merged 8 commits into from
May 15, 2024

Conversation

bfoley13
Copy link
Member

Description

  • Separated workflow logic into pkg/cli specific areas
  • Fixed prompt exemption logic
  • added default handling on pkg side for all generation components
  • added new generator label to all generated manifests with default value of draft and prompt exemption

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Pipelines

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Adding defaulting params to deployments and new label
* Separate workflow gen cli/pkg

* remove files

* make sure to copy inputs

* handle empty string variables
@imiller31
Copy link
Collaborator

Some failures with unsubstituted vars?
Error: error substituting file workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml: unsubstituted variable: {{BRANCHNAME}}, {{AZURECONTAINERREGISTRY}}, {{CONTAINERNAME}}, {{RESOURCEGROUP}}, {{CLUSTERNAME}}

@bfoley13
Copy link
Member Author

Some failures with unsubstituted vars? Error: error substituting file workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml: unsubstituted variable: {{BRANCHNAME}}, {{AZURECONTAINERREGISTRY}}, {{CONTAINERNAME}}, {{RESOURCEGROUP}}, {{CLUSTERNAME}}

Was copying the wrong flag variable into the customInput variables, fixed the issue!

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit 7975039 into Azure:main May 15, 2024
149 checks passed
@bfoley13 bfoley13 mentioned this pull request May 16, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants