-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GetManifestFiles() and refactoring #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasachi
changed the title
cherry-picked last changes, pushing new
Adding GetManifestFiles() and refactoring
Jul 24, 2024
manasachi
force-pushed
the
mchinta/getmanifestfiles
branch
from
July 25, 2024 13:01
2acbef3
to
8048731
Compare
NickKeller
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - but can you change the import alias to something more descriptive than just h
?
NickKeller
approved these changes
Jul 25, 2024
tbarnes94
approved these changes
Jul 25, 2024
manasachi
added a commit
that referenced
this pull request
Jul 30, 2024
manasachi
added a commit
that referenced
this pull request
Jul 31, 2024
sallasindhuja
pushed a commit
that referenced
this pull request
Aug 22, 2024
manasachi
added a commit
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested that validate.go does not break with removing code from run(). Added separate test cases for GetManifestFiles()
Checklist: