Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Manifest Path property, replacing with []byte content #355

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

manasachi
Copy link
Contributor

Description

Replacing ManifestFile Path property with yaml content as []byte. There is no need to write rendered manifests to a temporary directory now. Manifests are rendered and written in memory for validation to handle later.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Unit tests were updated to ensure validation is not dependent on writing rendered files to a temp dir. All files are written/returned in memory

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@manasachi manasachi changed the base branch from main to staging-safeguards July 31, 2024 18:59
@manasachi manasachi merged commit 2159479 into staging-safeguards Jul 31, 2024
149 checks passed
@manasachi manasachi deleted the mchinta/rmManifestPath branch July 31, 2024 19:14
This was referenced Aug 12, 2024
manasachi added a commit that referenced this pull request Oct 7, 2024
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants