Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Generic Template Handler #391

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Adding Generic Template Handler #391

merged 7 commits into from
Oct 7, 2024

Conversation

bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Oct 3, 2024

Description

This is the addition of the generic template handler, some template definition validation, and some documentation. This will not block/break any existing template/cli logic as it does not integrate it yet

Next steps in the next PR will be to:

  • Update all templates to using Draftconfig within the templates
  • Migrate old handlers(deployments/workflows/dockerfiles/etc.) to use generic template handler
  • Add test logic to the generic template handler. Cant do this yet as we have no template definitions that are migrated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 marked this pull request as ready for review October 4, 2024 15:23
@bfoley13 bfoley13 enabled auto-merge (squash) October 4, 2024 16:17
Copy link
Contributor

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the most part just a few suggestions

pkg/config/draftconfig.go Show resolved Hide resolved
pkg/handlers/template.go Outdated Show resolved Hide resolved
pkg/config/draftconfig.go Show resolved Hide resolved
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bfoley13 bfoley13 merged commit abc79e6 into main Oct 7, 2024
149 checks passed
@bfoley13 bfoley13 deleted the brfole/newhandlers branch October 7, 2024 17:22
bfoley13 added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants