feat: scheduler (11/): add more scheduler logic #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
reviewed
Jul 4, 2023
| ) (toCreate, toUpdate, toDelete []*fleetv1beta1.ClusterResourceBinding, err error) { | ||
| // Pre-allocate with a reasonable capacity. | ||
| toCreate = make([]*fleetv1beta1.ClusterResourceBinding, 0, len(picked)) | ||
| toUpdate = make([]*fleetv1beta1.ClusterResourceBinding, 0, 20) |
There was a problem hiding this comment.
Hi Ryan! It's just a number that's larger enough than the max. number of clusters in use by most interviewees as reported by the CNCF survey (10 IRC) but not too large to over-allocate memory. The reason it's added here is that it feels a little bit overkill to do some counting just for the purpose of allocating arrays.
michaelawyu
force-pushed
the
scheduler-framework-logic-3
branch
from
dcb1707
to
2e07966
Compare
zhiying-lin
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is part of the PRs that implement the Fleet workload scheduling.
It features more scheduling logic for PickAll type CRPs.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
To control the size of the PR, certain unit tests are not checked in; they will be sent in a separate PR.