feat: add the subindex annotation #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
previously approved these changes
Jul 10, 2023
|
The actual name in use for resource snapshots is not updated; is this expected? |
ryanzhang-oss
previously approved these changes
Jul 11, 2023
michaelawyu
reviewed
Jul 11, 2023
michaelawyu
reviewed
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Now the first snapshot name will always be {CRPName}-{resourceIndex}-snapshot.
It helps to solve the duplication of resourceSnapshotName and now the name format is fixed and there is no ambiguity.
This approach is simpler compared with other options' complexity otherwise the CRP name cannot contain "-" and not supporting it will hurt customer's experience.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer