-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate the time we need to wait for the first applied but not ready binding to be ready. #888
Conversation
3cb80bd
to
4b8bdb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should piggy back the min wait time in the pickBindingsToRoll function as it goes through all bindings already
2e91e34
to
176ae52
Compare
b9ce336
to
b8e31db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would good to have an integration test to test this
b1f5e3c
to
dade247
Compare
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer