feat: add counter prometheus metric from fleet guard rail rejection #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
commented
Sep 25, 2024
| @@ -57,13 +59,16 @@ func ValidateUserForFleetCRD(req admission.Request, whiteListedUsers []string, g | |||
| } | |||
|
|
|||
| // ValidateUserForResource checks to see if user is allowed to modify argued resource modified by request. | |||
| func ValidateUserForResource(req admission.Request, whiteListedUsers []string) admission.Response { | |||
| func ValidateUserForResource(req admission.Request, whiteListedUsers []string, isTerminalCall bool) admission.Response { | |||
There was a problem hiding this comment.
We call this function here https://github.com/Azure/fleet/blob/main/pkg/webhook/fleetresourcehandler/fleetresourcehandler_webhook.go#L151 where we don't reject immediately, we call another function to allow/reject hence added the isTerminalCall variable to enable counting the rejection correctly
|
Looks like the API Server exposes the rejection count as a prometheus metric by default https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#admission-webhook-metrics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer