Fix int overflow #33
Merged
Fix int overflow #33
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
fix_int_overflow
branch
3 times, most recently
from
8a69844 to
7879a6d
Compare
|
Test run here: https://github.com/cpuguy83/go-ansiterm/pull/5/checks?check_run_id=2853454830 Apparently there's another bug as well which should be fixed by #27 |
cpuguy83
force-pushed
the
fix_int_overflow
branch
2 times, most recently
from
69bcbca to
d70676d
Compare
cpuguy83
force-pushed
the
fix_int_overflow
branch
3 times, most recently
from
d227edb to
cce61a1
Compare
See golang/go#32479 Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
cpuguy83
force-pushed
the
fix_int_overflow
branch
from
cce61a1 to
5a086cd
Compare
thaJeztah
reviewed
Jun 17, 2021
| // syscall uses negative numbers | ||
| // windows package uses very big uint32 | ||
| // Keep these switches split so we don't have to convert ints too much. | ||
| switch uint32(nFile) { |
There was a problem hiding this comment.
I went over a few variations as well; would casting to int64 work? docker/cli@97da45d
There was a problem hiding this comment.
It does, but I figured it would be better to split since these are really different types.
There was a problem hiding this comment.
Yeah, I think ultimately we should drop the syscall one (and introduce a breaking change once)
|
This time we got it for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27