Allow a new authorizer to be created from a configuration file by specifying a resource instead of a base url. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cifying a resource instead of a base url. This enables resource like KeyVault and Container Registry to use an authorizer configured from a configuration file.
nphmuller
force-pushed
the
NewAuthFromFileWithResource
branch
from
d39a90f
to
39469b0
Compare
|
This is related to Azure/azure-sdk-for-go#2610 |
|
@marstr This PR just allows the NewAuthorizerFromFile flow to be used with every resource. Before the changes in this PR the only way to use this flow was by providing a baseurl, which was used to determine the resource url. Downside was that some resources like KeyVault cannot be determined this way (afaik), so I've basically provided an overload where the user can provide the resource url directly. This overload already exists for the NewAuthorizerFromEnvironment flow. |
marstr
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables resource like KeyVault and Container Registry to use an authorizer configured from a configuration file.