Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation in resource id parsing #704

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

karataliu
Copy link
Contributor

@karataliu karataliu commented Jun 24, 2022

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

Before fix, 'ANYSTRING+valid id' can also be parsed as valid id, that's not correct.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

@jhendrixMSFT
Copy link
Member

Can you please provide a brief description of what's broken without this fix?

@karataliu
Copy link
Contributor Author

@jhendrixMSFT
That's in description, without the fix:
ABCDEF/subscription/xxx/resourcegroup/xxx/... is considered a valid id, but actually not.

@jhendrixMSFT jhendrixMSFT merged commit 2fa44cb into Azure:main Aug 8, 2022
@karataliu karataliu deleted the pf branch August 9, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants