Added NuGet Package for .Net Framework target. #103
Conversation
|
Hi @barnstee, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Using debug version of gateway.dll for now for better diagnosability.
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Azure.IoT.Gateway.SDK.Net</id> | ||
| <version>2017.01.13.2</version> |
There was a problem hiding this comment.
2017.01.13.2 [](start = 13, length = 12)
Investigate if this is supported by Nuget. I am not sure, and don't recall seeing this in packages I worked with.
There was a problem hiding this comment.
Yeah, I think it's needs to be 2017.01.13-2, checking...
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/nuget/create-packages/prerelease-packages#semantic-versioning
So it needs to be 2017.01.13-alpha
2. Made everything release (heap corruption needs to be fixed for this) 3. Split the GW and ,Net binding up into seperate packages. 4. Fixed versioning string
| <files> | ||
| <file src="..\bindings\dotnet\dotnet-binding\Microsoft.Azure.IoT.Gateway\bin\x86\Release\Microsoft.Azure.IoT.Gateway.dll" target="lib\net40" /> | ||
| <file src="..\bindings\dotnet\dotnet-binding\Microsoft.Azure.IoT.Gateway\bin\x86\Release\Microsoft.Azure.IoT.Gateway.pdb" target="lib\net40" /> | ||
| <file src="..\build\core\Debug\gateway.dll" target="build\x86" /> |
There was a problem hiding this comment.
HI @barnstee , all other binaries are release and this one is Debug. Shall we keep the same type (All Release or All Debug?).
| <file src="..\build\modules\iothub\Release\iothub.dll" target="build\x86" /> | ||
| <file src="..\install-deps\bin\aziotsharedutil.dll" target="build\x86" /> | ||
| <file src="..\install-deps\bin\iothub_client.dll" target="build\x86" /> | ||
| <file src="..\install-deps\bin\iothub_service_client.dll" target="build\x86" /> |
There was a problem hiding this comment.
Do we need to add this DLL on our package? I think we have already Nuget Packages for it. Shall we add this as a dependence?
Same for aziotsharedutil.dll, iothub_client.dll, serializer.dll....
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Azure.IoT.Gateway.SDK.Net</id> | ||
| <version>2017.01.13.2</version> |
There was a problem hiding this comment.
Shall this version match with the Release Tag Version?
| <title>Azure IoT Gateway SDK for .Net Framework</title> | ||
| <description>This package contains the Microsoft Azure IoT Gateway SDK targeting the .NET Framework</description> | ||
| <id>Azure.IoT.Gateway.SDK</id> | ||
| <version>2017.01.13-alpha</version> |
| <file src="..\install-deps\bin\aziotsharedutil.dll" target="build\x86" /> | ||
| <file src="..\install-deps\bin\aziotsharedutil.pdb" target="build\x86" /> |
There was a problem hiding this comment.
From here to below we should change to instead of adding these binaries on our package we should add them as dependencies.
According to Tamer (From IOT SDK) all of these has different Nuget Packages.
Can you check it out @barnstee ?
| <file src="..\install-deps\bin\iothub_service_client.dll" target="build\x86" /> | ||
| <file src="..\install-deps\bin\iothub_service_client.pdb" target="build\x86" /> | ||
| <file src="..\install-deps\bin\nanomsg.dll" target="build\x86" /> |
There was a problem hiding this comment.
This one may be an exception. If they don't have a nuget package we can add them.
| <tags>Microsoft Azure IoT Gateway SDK</tags> | ||
| </metadata> | ||
| <files> | ||
| <file src="..\build\core\Release\gateway.dll" target="build\x86" /> |
There was a problem hiding this comment.
What's the intention to refer x86 bits here ?
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Azure.IoT.Gateway.SDK.Net</id> | ||
| <version>2017.01.13-alpha</version> |
There was a problem hiding this comment.
For version of Nuget, we shall use the semantic version(MAJOR.MINOR.HOTFIX). And it seems that the SDK team bumped a version file during build time: $azure-iot-gateway-sdk\tools\release\bump_version\versions.json, maybe we should use that one. Does nuspec support template ?
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="..\bindings\dotnet\dotnet-binding\Microsoft.Azure.IoT.Gateway\bin\x86\Release\Microsoft.Azure.IoT.Gateway.dll" target="lib\net40" /> |
There was a problem hiding this comment.
Instead of use relative path, which will be harder to maintain in the future. Can you use absolute path which is read from current build environment ?
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Azure.IoT.Gateway.SDK</id> |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
| <metadata> | ||
| <id>Azure.IoT.Gateway.SDK.Net</id> |
There was a problem hiding this comment.
Shall we use a common naming here which is independent of PLAN ? Azure.IoT.Gateway.Binding ?
|
There's a much larger effort in process right now to produce gateway SDK packages for various platforms & languages, starting with NuGet/.NET. This will include our engineering process for publishing packages, so the actual .nuspec file is a relatively minor detail. Since this PR has stalled a bit, we're going to close it. The work that was already scheduled (just getting underway now) will continue. Thanks! |
NuGet package contains everything you need to design & build a .Net-based GW module. Things that still need to be fixed in the SDK: