Remove packages.microsoft.com registration from test script #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsing
approved these changes
Jun 4, 2024
damonbarry
added a commit
to damonbarry/iot-identity-service
that referenced
this pull request
Jun 4, 2024
The custom agents which run the end-to-end test workflows (manual and scheduled) already register packages.microsoft.com with apt, and they sign the registration with a specific keyring file. This clashes with the method of registration happening in the end-to-end tests, causing errors like: ``` Setting up packages-microsoft-prod (1.0-ubuntu22.04.1) ... E: Conflicting values set for option Signed-By regarding source https://packages.microsoft.com/ubuntu/22.04/prod/ jammy... ``` This change removes the redundant and conflicting registration from the test script. It is assumed that packages.microsoft.com has already been registered when the tests run. To test, I ran the manual workflow against the PR and verifying that it got past the above error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom agents which run the end-to-end test workflows (manual and scheduled) already register packages.microsoft.com with apt, and they sign the registration with a specific keyring file. This clashes with the method of registration happening in the end-to-end tests, causing errors like:
This change removes the redundant and conflicting registration from the test script. It is assumed that packages.microsoft.com has already been registered when the tests run.
To test, I ran the manual workflow against the PR and verifying that it got past the above error.