Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use managed identity for end-to-end tests #617

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Use managed identity for end-to-end tests #617

merged 3 commits into from
Jun 11, 2024

Conversation

damonbarry
Copy link
Member

This change upgrades the scheduled and manual end-to-end test workflows and scripts to login to Azure CLI using a managed identity that has been installed on the customer runner VMs. It eliminates the need to generate a app secret and store it in the workflow.

To test, I ran the manual workflow with these changes and confirmed that it can still create Azure resources.

@damonbarry damonbarry requested a review from arsing June 11, 2024 00:59
docs-dev/e2e-tests.md Outdated Show resolved Hide resolved
Co-authored-by: Arnav Singh <arsing@microsoft.com>
@kodiakhq kodiakhq bot merged commit c1b3dda into main Jun 11, 2024
130 checks passed
@kodiakhq kodiakhq bot deleted the e2e-msi branch June 11, 2024 16:05
damonbarry added a commit to damonbarry/iot-identity-service that referenced this pull request Jun 12, 2024
This change upgrades the scheduled and manual end-to-end test workflows and scripts to login to Azure CLI using a managed identity that has been installed on the customer runner VMs. It eliminates the need to generate a app secret and store it in the workflow.

To test, I ran the manual workflow with these changes and confirmed that it can still create Azure resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants