Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload/download-artifacts action to v4 #640

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update upload/download-artifacts action to v4 #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
os_package="$(sed -e 's@[:/]@-@g' <<< "$os_package")"
echo "artifact-name=packages_${os_package}_${{ matrix.arch }}" >> $GITHUB_OUTPUT
- name: 'Upload'
uses: 'actions/upload-artifact@v3'
uses: 'actions/upload-artifact@v4'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'packages'
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
build-info: true

- name: 'Upload'
uses: 'actions/upload-artifact@v3'
uses: 'actions/upload-artifact@v4'
with:
name: 'packages_snap_${{ matrix.runner.arch }}'
path: '${{ steps.snapcraft.outputs.snap }}'
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
esac
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Upload'
uses: 'actions/upload-artifact@v3'
uses: 'actions/upload-artifact@v4'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: |
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Download'
id: 'download-artifact'
uses: 'actions/download-artifact@v3'
uses: 'actions/download-artifact@v4'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'target/debug'
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Download'
id: 'download-artifact'
uses: 'actions/download-artifact@v3'
uses: 'actions/download-artifact@v4'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'target/debug'
Expand Down
6 changes: 5 additions & 1 deletion ci/e2e-tests/test-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,17 @@ get_package() {
return
fi

# The download-artifact action does not have a way to download artifacts from other workflows.
# The download-artifact@v3 action does not have a way to download artifacts from other workflows.
# Ref: https://github.com/actions/download-artifact/issues/3
#
# So instead we use the GitHub API ourselves.
#
# It would be nice to use the v4 graphql API and get the artifact URL in one shot,
# but it doesn't appear to support artifacts.
#
# The download-artifact@v4 action now supports downloading artifacts from other workflows, but
# we'd need to evaluate it. See
# https://github.com/actions/download-artifact#download-artifacts-from-other-workflow-runs-or-repositories

github_curl() {
if [ -n "${GITHUB_PAT:-}" ]; then
Expand Down
Loading