Fix #371 #372
Fix #371 #372
Conversation
iotedgedev/modules.py
Outdated
| @@ -145,7 +145,7 @@ def build_push(self, template_file, default_platform, no_build=False, no_push=Fa | |||
| # get the Dockerfile from module.json | |||
| dockerfile = module.get_dockerfile_by_platform(platform) | |||
| container_tag = "" if self.envvars.CONTAINER_TAG == "" else "-" + self.envvars.CONTAINER_TAG | |||
| tag = "{0}:{1}{2}-{3}".format(module.repository, module.tag_version, container_tag, platform).lower() | |||
| tag = "{0}:{1}{2}-{3}".format(module.repository, module.tag_version, container_tag, platform) | |||
There was a problem hiding this comment.
FYI for future reviewers...this comment can be closed.
Image name needs to be lower case. module.repository = {server}/{name}, so you need to call .lower on that, but not on the tag. I have confirmed that name.lower is called earlier in the code.
| - powershell: | | ||
| choco install jdk11 | ||
| $env:JAVA_HOME = "C:\Program Files\Java\jdk-11.0.1" | ||
| choco install jdk8 --version 8.0.201 |
There was a problem hiding this comment.
Switch to JDK8 because it's already specified as a dependency of maven. Installing JDK11 will cost more time and space.
|
Currently CI build will fail on Windows agents only because Windows agents are still based on 1803 while the scaffolded Dockerfiles are based on 1809 (Azure DevOps' 1809 support is coming by end of Feb). |
setup.py
Outdated
| @@ -32,9 +32,10 @@ def run(self): | |||
| 'Click>=6.0', | |||
| 'docker>=3.5', | |||
| 'python-dotenv', | |||
| 'requests', | |||
| 'requests<2.21', | |||
There was a problem hiding this comment.
what is the issue if use higher version?
There was a problem hiding this comment.
And can we make sure what is the lowest version supported?
There was a problem hiding this comment.
Similar conflict with docker-compose https://github.com/docker/compose/blob/master/setup.py#L36
There was a problem hiding this comment.
Lower bound specified.
setup.py
Outdated
| 'fstrings', | ||
| 'msrestazure~=0.4.32', | ||
| 'azure-cli-core<2.0.55', |
There was a problem hiding this comment.
azure-cli-core depends on a beta version of PyYAML starting version 2.0.55, which will conflict with docker-compose. See #373
There was a problem hiding this comment.
There was a problem hiding this comment.
Lower bound specified.
No description provided.