Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a invalid check in pr-check workflow for supporting MI PR #352

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

YanaXu
Copy link
Collaborator

@YanaXu YanaXu commented Oct 13, 2023

This update is for #348.
In #348, PS login will set subscription id if it exists even if "allow-no-subscriptions" is true. In this case, the commented line will fail since the account does not have the right permission for the configured subscription. (Generally, this should not happen.)

@YanaXu YanaXu temporarily deployed to Automation test October 13, 2023 02:42 — with GitHub Actions Inactive
@YanaXu YanaXu requested a review from MoChilia October 13, 2023 02:48
@YanaXu YanaXu merged commit a00376e into master Oct 13, 2023
20 checks passed
@YanaXu YanaXu deleted the yanxu/pr_check_workflow branch October 13, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant