Update Workflows #385
Merged
Update Workflows #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
temporarily deployed
to
Automation test
GitHub Actions
Inactive
YanaXu
approved these changes
Dec 27, 2023
|
@jsoref, thanks for your contribution! |
jsoref
commented
Dec 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently use azure/powershell@v1 -- some were using specific old versions and some were getting the latest -- there was no particular reason for this
Consistently use actions/checkout@v4 -- some were using very old (v2), some were using specifically pinned (v3.5.2), and others a floating but outdated version (v3) -- there was no particular reason for this
Consistently use actions/setup-node@v4 -- some were using the original version (v1) and some the previous version (v3) -- there was no particular reason for this
Consistently use actions/github-script@v7 -- everyone was using a fairly old version (v3) -- the code here is simple and supported -- there's no reason not to use the current version (old versions will stop working as they rely on old versions of the actions runtime nodeX which are being discontinued incrementally)
Consistently use actions/stale@v8 -- two out of three were using an old version (v3) while one is actually already using the latest version!
Specify codql language as javascript -- CodeQL complains that it can't auto-detect TypeScript, but it will work happily if you tell it that it's JavaScript
Name ci.yml -- Workflows should have names so they look pretty in https://github.com/Azure/login/actions
CodeQL does not need a special code -- CodeQL got smarter and doesn't need special code for checkout