Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action's node version #392

Closed
wants to merge 2 commits into from
Closed

Conversation

eikooc
Copy link

@eikooc eikooc commented Dec 28, 2023

References these issues:
#357
#391

@vRune4
Copy link

vRune4 commented Feb 9, 2024

This update is probably not complete.

E.g. .github/workflows/azure-login-positive.yml contains this:

    - name: Set Node.js 16.x for GitHub Action
      uses: actions/setup-node@v4
      with:
        node-version: 16.x

I suspect the tests will have to be updated as well.

@eikooc
Copy link
Author

eikooc commented Feb 12, 2024

@vRune4 the mentioned code is not the action's version, but the version of an action this repository uses actions/setup-node@v4 for it's CI pipeline.

@MoChilia
Copy link
Member

Thanks a lot for your contribution, the change is merged in #411.

@MoChilia MoChilia closed this Feb 20, 2024
@eikooc eikooc deleted the update-node-version branch February 22, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants